cow: model Verdict::Post next-poll timestamp as Option<u64> - #593
Merged
Conversation
mfw78
added a commit
that referenced
this pull request
Jul 27, 2026
cow: model Verdict::Post next-poll timestamp as Option Closes #567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Verdict::Post::next_poll_timestampbecomesOption<u64>.Nonereplaces the0sentinel that meant "no next poll", so the absent case is typed rather than a magic value a caller can do arithmetic on by accident.Why
0as "no next poll" is indistinguishable from a genuine (if nonsensical) epoch-0 timestamp and lets a caller compute on it silently. Modelling it asOption<u64>makes the absent case explicit at every read.Testing
Full battery on the pinned 1.94 toolchain, all green:
nix develop --command just ci(fmt, clippy-D warnings, doc, module wasms,cargo test --workspace --all-features)nix develop --command just check-venue-agnosticnix develop --command just check-cow-orderbook-onlyAI Assistance
Implemented with Claude Code.
Closes #567